Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Initialize CI #4

Merged
merged 16 commits into from
Jul 22, 2024
Merged

Initialize CI #4

merged 16 commits into from
Jul 22, 2024

Conversation

plzfday
Copy link
Member

@plzfday plzfday commented Jul 18, 2024

What is this feature?

Setup CI file for GitHub Actions. Initially it was based on bun, but due to its instability with Next JS, it was changed to Yarn, a better toolkit for dependency management than npm.

Task Details

  • Add ci.yaml file for GitHub actions. This runs unit tests.
  • Add a sample unit test code that should be removed when merging other PRs.

Reference Materials (Optional)

@plzfday plzfday requested a review from utilForever July 18, 2024 17:53
@plzfday plzfday self-assigned this Jul 18, 2024
@plzfday plzfday linked an issue Jul 18, 2024 that may be closed by this pull request
Copy link
Member

@utilForever utilForever left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did you changed toolkit from bun to yarn?
It would be nice to have a description of why you made the change.

@plzfday
Copy link
Member Author

plzfday commented Jul 19, 2024

Did you changed toolkit from bun to yarn? It would be nice to have a description of why you made the change.

I have made a change in the description. Could you check it again, please?

@plzfday plzfday requested a review from utilForever July 19, 2024 17:15
Copy link
Member

@utilForever utilForever left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM now. Thanks for your work! 🎉
p.s. The reason why we need to add yarn.lock is its dependency?

@plzfday
Copy link
Member Author

plzfday commented Jul 22, 2024

Yes, exactly. AFAIK, we can keep the same version of dependencies in each of our local computers with the .lock file.

@utilForever
Copy link
Member

Yes, exactly. AFAIK, we can keep the same version of dependencies in each of our local computers with the .lock file.

Okay. I understand. Thanks~

@plzfday plzfday merged commit 2f3dff3 into main Jul 22, 2024
1 check passed
@plzfday plzfday deleted the 2-setup-ci branch July 22, 2024 06:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Setup CI
2 participants